Skip to content

/expo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get bare-expo compiling and running for Android #5987

Closed
ide opened this issue Oct 16, 2019 · 1 comment · Fixed by #6062
Closed

Get bare-expo compiling and running for Android #5987

ide opened this issue Oct 16, 2019 · 1 comment · Fixed by #6062
Assignees
@tsapeta
Labels
Launch-blocking
Projects
SDK 36

Comments

@ide
Copy link
Member

@ide ide commented Oct 16, 2019

bare-expo is not compiling for Android because both our copy of RN and RNGH define UIManagerReanimatedHelper. We need to tell Gradle to exclude the copy in RNGH.

Repro: cd into react-native-lab/react-native, run ./gradlew :ReactAndroid:installArchives (this takes time), cd into bare-expo/android, run ./gradlew assemble.

Error:

Execution failed for task ':app:transformDexArchiveWithDexMergerForRelease'.
> com.android.build.api.transform.TransformException: java.lang.RuntimeException: java.lang.RuntimeException: com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives: 
  Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes.
  Program type already present: com.facebook.react.uimanager.UIManagerReanimatedHelper
@ide ide added the Launch-blocking label Oct 16, 2019
@ide ide added this to To do in SDK 36 via automation Oct 16, 2019
@ide ide mentioned this issue Oct 16, 2019
Closed
10 of 11 tasks complete
@tsapeta

This comment has been minimized.

Sign in to view
Copy link
Member

@tsapeta tsapeta commented Oct 21, 2019

@ide Do we need to define our own UIManagerReanimatedHelper in react-native fork? Looks like they are the same, so maybe removing it from the fork would help?
@tsapeta tsapeta mentioned this issue Oct 23, 2019
Merged
SDK 36 automation moved this from To do to Done Oct 24, 2019
tsapeta added a commit that referenced this issue Oct 24, 2019
@tsapeta
[sdk36] Remove UIManagerReanimatedHelper from react-native fork and u…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
001fd14 
…pdate ReactAndroid (#6062)

# Why

Fixes #5987 

# How

- Removed `UIManagerReanimatedHelper` from the fork and added it to unversioned `expoview`. Ideally if we could update the command updating vendored modules to pull this file directly from `react-native-reanimated` but I think it's of less priority now since this file is not going to change.

- Updated `ReactAndroidCodeTransformer` to properly handle changes in `ExceptionsManagerModule` from RN.

- Updated `ReactAndroid` and `ReactCommon` folders, they were not in sync with `react-native` submodule.

# Test Plan

Running `./gradlew assemble` at `apps/bare-expo` works and `client_android` job passes now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsapeta tsapeta

Labels
Launch-blocking
Projects
SDK 36
  
Done
Milestone
No milestone
2 participants
@ide @tsapeta
You can’t perform that action at this time.