[expo-notifications] Fix exception sometimes being thrown if observer is cleared before it's registered #10640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k reference to the helper, leak the observer consciously
sjchmiela
changed the title
cruzach
reviewed
Oct 12, 2020
| @@ -121,7 +121,7 @@ public static void addListener(NotificationManager listener) { | |||
| } | |||
| } | |||
|
|
|||
| private boolean mIsAppInForeground = false; | |||
| private boolean mIsAppInForeground = ProcessLifecycleOwner.get().getLifecycle().getCurrentState().isAtLeast(Lifecycle.State.RESUMED); | |||
cruzach
approved these changes
Oct 12, 2020
|
Hi @sjchmiela, thank you so much for the PR 🎉 I'm not an Android developer, so sorry if this question is dummy. I'm trying to test this PR but I'm getting the following error: I tested adding the import but I get the same error. Of course I created Sorry if this question is dummy and again, thank you so much for your support! |
|
Hey @RodolfoGS! Thank you so much for trying to test this PR! It it indeed related to Kotlin — on |
sjchmiela
added a commit
that referenced
this pull request
Oct 14, 2020
…vice delegate (#10666) # Why A prerequisite to single-threaded notifications handling. # How More refactoring, moving staff from `NotificationsHelper` to appropriate `NotificationsService`' delegates. This time to `ExpoHandlingDelegate`. In the meantime I have also removed a memory leak introduced in #10640 — we don't need to _observe_ the state, we can check for the state every time we need to access it. # Test Plan Push and scheduled notifications are presented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Probably fixes #10610.
How
Looked into the stacktrace, noticed that we may be trying to add a
nullobserver to the registry (origin, the observer is saved in aWeakReference).Since we really want the observer to be saved and we don't have infrastructure to notify
NotificationsHelperof its destroy we need to leak the observer (a refactor removing need for this is currently in the works). If we need to leak the observer lets leak just as little as we can (just the observer, not the helper). So I created a simple class forwarding interesting calls to the helper.Test Plan
I have tested the code manually (verified that the callbacks are called correctly).