Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update filesystem.mdx #19577

Closed
wants to merge 1 commit into from
Closed

[docs] Update filesystem.mdx #19577

wants to merge 1 commit into from

Conversation

StCyr
Copy link

@StCyr StCyr commented Oct 17, 2022

getContentUriAsync doesn't do anything on iOS

fixes #19578

getContentUriAsync doesn't do anything on iOS
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Oct 17, 2022
@brentvatne
Copy link
Member

this is indeed correct! @amandeepmittal @Simek - can you review for docs style?

@amandeepmittal amandeepmittal changed the title Update filesystem.mdx [docs] Update filesystem.mdx Nov 26, 2022
@@ -584,7 +584,9 @@ Returns an object with the following fields:

### `FileSystem.getContentUriAsync(fileUri)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @StCyr,

These docs have been moved to more "autogenerating" API recently. You will have to add a platform @Android tag in this file (the content of this function starts from line number 92):

* Takes a `file://` URI and converts it into content URI (`content://`) so that it can be accessed by other applications outside of Expo.

This will indicate that this function is to be used only for Android as shown below:

CleanShot 2022-11-28 at 00 06 03@2x

After you make the changes, I can backport them to the SDK versions.

Sorry for the long process 😅

@amandeepmittal
Copy link
Member

The doc is now up to date:

CleanShot 2023-07-17 at 16 32 14@2x

Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] getContentUriAsync
4 participants