[camera] stopRecording, pausePreview and resumePreview have been updated to return promises
#25737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n updated to return promises
alanjhughes
approved these changes
Dec 4, 2023
Kudo
approved these changes
Dec 4, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…n updated to return promises (expo#25737) # Why `stopRecording`, `pausePreview`, and `resumePreview` should return promises. Otherwise, users can't wait for the response from the native code. # Test Plan - test-suite ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
stopRecording,pausePreview, andresumePreviewshould return promises. Otherwise, users can't wait for the response from the native code.Test Plan