[android] Remove obsolete assets from standalone apps #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjchmiela
added
in progress
project: sdk
and removed
in progress
status: in review
labels
sjchmiela
force-pushed
the
@sjchmiela/remove_kernel_android_bundle
branch
from
f390f71
to
fd80a1b
Compare
esamelson
approved these changes
Nov 30, 2018
sjchmiela
force-pushed
the
@sjchmiela/remove_kernel_android_bundle
branch
from
fd80a1b
to
c4a0400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
kernel.android.bundleisn't used in standalone apps yet we include it in every ejected or standalone apps. expo/expo-cli#225 will ensure this file is removed from sources when building app, so we shouldn't point an embedded response to it.EmojiOne.ttffirstly isn't a valid TTF file, secondly doesn't seem to be used anywhere anymore.How
Remove embedded response from
Constants.java, removeEmojiOne.ttfand its licence fromTHIRD-PARTY-LICENSES.Test Plan
I'll deploy staging Turtle with this change and see if the app works properly.
It does! APK
This PR cuts down APK size by 5 MBs (3 MBs for
EmojiOne.ttf, 2 MBs forkernel.android.bundle). 馃帀