Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix GLView initialization with 0 size texture #2907

Merged
merged 1 commit into from Dec 6, 2018

Conversation

@bbarthec
Copy link
Member

commented Dec 4, 2018

Why

Resolves #2671

How

Android while creating surfaceTexture sometimes returns texture that has 0 size.
Immediately ofter such incident correct sized texture is provided via different callback.

Test Plan

https://snack.expo.io/@barthec/glview-sdk31

@bbarthec bbarthec requested a review from tsapeta Dec 4, 2018

@bbarthec bbarthec force-pushed the @bbarthec/glview-android-sdk31 branch from ca3f70f to f1d558d Dec 4, 2018

@tsapeta
Copy link
Member

left a comment

Good work Bartek! Thanks for fixing this 😄

@bbarthec bbarthec force-pushed the @bbarthec/glview-android-sdk31 branch from f1d558d to f5b6d3d Dec 5, 2018

@tsapeta
tsapeta approved these changes Dec 6, 2018

@tsapeta tsapeta merged commit 2750edd into master Dec 6, 2018

2 checks passed

client Workflow: client
Details
sdk Workflow: sdk
Details

@tsapeta tsapeta deleted the @bbarthec/glview-android-sdk31 branch Dec 6, 2018

@tsapeta tsapeta removed the in progress label Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.