Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Splash screen in standalone app fixes #3029

Merged
merged 6 commits into from Feb 6, 2019

Conversation

@bbarthec
Copy link
Member

commented Dec 20, 2018

Why

Resolves #2533
Corresponding docs for expo/expo-cli#268

  • update xdl package in tool-public to one containing above expo-cli changes

@bbarthec bbarthec requested review from sjchmiela, tsapeta and esamelson Dec 20, 2018

@@ -138,7 +138,7 @@ export default class App extends React.Component {
}
```

## Example without any flickering between SplashScreen and it's later continueation
## Example without any flickering between SplashScreen and it's later continuation

This comment has been minimized.

Copy link
@bbarthec

bbarthec Dec 20, 2018

Author Member

This is only explicit change I've made, all the rest is just auto-behaviour of my IDE

@@ -670,23 +670,26 @@ Configuration for how and when the app should request OTA JavaScript updates
"backgroundColor": STRING,
/*
Determines how the "image" will be displayed in the splash loading screen.
Must be one of "cover" or "contain", defaults to "contain".
Determines how the "image" will be displayed in the splash loading screen.

This comment has been minimized.

Copy link
@bbarthec

bbarthec Dec 20, 2018

Author Member

My explicit changes are here, the rest is just out-fixing made by my IDE

@tsapeta
Copy link
Member

left a comment

Added suggestions about some typos 😉

docs/versions/unversioned/guides/splash-screens.md Outdated Show resolved Hide resolved
docs/versions/unversioned/guides/splash-screens.md Outdated Show resolved Hide resolved
docs/versions/unversioned/guides/splash-screens.md Outdated Show resolved Hide resolved

@bbarthec bbarthec added in review and removed in progress labels Dec 20, 2018

@esamelson
Copy link
Member

left a comment

Looks good, can you make sure to add a CHANGELOG entry as well since this may be a breaking change for people (they may need to switch from "contain" to "cover" or vice versa)?

@bbarthec bbarthec force-pushed the @bbarthec/splash-screen-standalone-app branch from dc037b6 to db6acd3 Jan 8, 2019

@sjchmiela
Copy link
Contributor

left a comment

Nice one, I don't know if all my suggestions make sense. Nice job! 💯

docs/versions/unversioned/guides/splash-screens.md Outdated Show resolved Hide resolved
docs/versions/unversioned/guides/splash-screens.md Outdated Show resolved Hide resolved
docs/versions/unversioned/guides/splash-screens.md Outdated Show resolved Hide resolved
docs/versions/unversioned/guides/splash-screens.md Outdated Show resolved Hide resolved
docs/versions/unversioned/guides/splash-screens.md Outdated Show resolved Hide resolved
docs/versions/unversioned/guides/splash-screens.md Outdated Show resolved Hide resolved

@bbarthec bbarthec removed the in review label Jan 15, 2019

@bbarthec bbarthec changed the title @bbarthec/splash screen standalone app [Android] Splash screen in standalone app fixes Jan 22, 2019

@bbarthec bbarthec force-pushed the @bbarthec/splash-screen-standalone-app branch 3 times, most recently from 682b13c to c9a95b1 Feb 6, 2019

@bbarthec bbarthec force-pushed the @bbarthec/splash-screen-standalone-app branch from c9a95b1 to 48cef83 Feb 6, 2019

@bbarthec bbarthec merged commit 0ab2078 into master Feb 6, 2019

2 of 3 checks passed

client Workflow: client
Details
docs Workflow: docs
Details
sdk Workflow: sdk
Details

@bbarthec bbarthec deleted the @bbarthec/splash-screen-standalone-app branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.