Conversation
|
Subscribed to pull request
Generated by CodeMention |
behenate
left a comment
There was a problem hiding this comment.
Hi, looks good! Can you just add an entry to to packages/expo-local-authentication/CHANGELOG.md before we merge?
|
Hi @behenate, I added an entry now. Thanks. |
|
@dcangulo You will also have to run |
|
@behenate Done! |
|
Sorry last thing, there seems to be a lint error: |
|
@behenate Done! |
|
jus add cancelLabel: "Cancel", const biometric = await authenticateAsync({ |
Why
LocalAuthentication.authenticateAsyncon Android crashes whendisableDeviceFallbackistrue. This line specifically: https://github.com/expo/expo/blob/main/packages/expo-local-authentication/android/src/main/java/expo/modules/localauthentication/LocalAuthenticationModule.kt#L225Closes #32075 and #30556
How
The docs (https://docs.expo.dev/versions/latest/sdk/local-authentication/#localauthenticationoptions), says that the
cancelLabelhas a default value ofCancel.I just made it explicit so that it will have the default value whether
disableDeviceFallbackistrueorfalseand it won't cause a crash due to not providing it.Test Plan
This code must not crash on Android:
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).