Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] In-App Purchases #4607

Merged
merged 18 commits into from Jul 2, 2019

Conversation

@sergeichestakov
Copy link
Member

commented Jun 14, 2019

Why

Documentation for the In-App Purchases module introduced in #4416.

Test Plan

Run yarn run dev in the docs/ directory and go to http://localhost:3000/versions/unversioned/sdk/in-app-purchases/.

@cruzach
Copy link
Contributor

left a comment

this is really good, just a few minor changes to clean it up

@esamelson
Copy link
Member

left a comment

this looks solid. just a couple of questions for places you can clarify/expand on.

sergeichestakov added some commits Jun 23, 2019

@ide

ide approved these changes Jun 25, 2019

@sergeichestakov sergeichestakov merged commit 129e3d1 into master Jul 2, 2019

2 of 3 checks passed

client Workflow: client
Details
docs Workflow: docs
Details
sdk Workflow: sdk
Details

@sergeichestakov sergeichestakov deleted the @sergeichestakov/iap-docs branch Jul 2, 2019

@kmbro

This comment has been minimized.

Copy link

commented Jul 2, 2019

Hi sergeichestakov, I would love to see this in-app-purchases module as part of the managed workflow. I want to help make that happen as soon as possible. I have read the contributing guide, but thought I would reach out to see what you need to help make this module part of the managed workflow! Thanks
kmbro

@sergeichestakov

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

Hey @kmbro,

Thanks for reaching out. This module is currently only available in the bare workflow for a number of reasons described here. I'd love for this to be included in the managed workflow too but unfortunately that's not feasible at the moment.

With that being said, the module is finally released and ready for use in bare apps. Check out the docs here: https://docs.expo.io/versions/latest/sdk/in-app-purchases/

Thanks,
Sergei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.