Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update audio.md #5059

Merged
merged 3 commits into from Jul 29, 2019

Conversation

@nmaruy27
Copy link
Contributor

commented Jul 24, 2019

Since createNewLoadedSound has been deprecated, it has been modified to use the alternative createNewLoadedSoundAsync.

Update audio.md
Since createNewLoadedSound has been deprecated, it has been modified to use the alternative createNewLoadedSoundAsync.
@cruzach

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Great! Thanks for fixing this 😄

Could you make the same change to the unversioned docs, as well?
https://github.com/expo/expo/blob/master/docs/pages/versions/unversioned/sdk/audio.md

@nmaruy27

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Thank you for reply.

What I fixed is unversioned.
Are you talking about other versions? For example, v34.0.0, v33.0.0, etc.

@cruzach

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

Yeah sorry for the confusion, I meant v33 and v34

nmaruy27 added some commits Jul 27, 2019

Update audio.md
Since createNewLoadedSound has been deprecated, it has been modified to use the alternative createNewLoadedSoundAsync.
Update audio.md
Since createNewLoadedSound has been deprecated, it has been modified to use the alternative createNewLoadedSoundAsync.
@nmaruy27

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2019

@cruzach
OK. I made the same change to v33 and v34.

@cruzach cruzach merged commit 40387ef into expo:master Jul 29, 2019

2 of 3 checks passed

client Workflow: client
Details
docs Workflow: docs
Details
sdk Workflow: sdk
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.