Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-av] Do not reset player if source doesn't change #5106

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@sjchmiela
Copy link
Contributor

commented Jul 30, 2019

Why

Fixes #5084.

How

setSource: was called whenever any prop changed (proxiedProperties thing). Now setSource: will be called only when the source actually changes.

Test Plan

Reproducing Snack no longer alerts 'loaded' every tap.

@sjchmiela sjchmiela requested review from tsapeta and mczernek Jul 30, 2019

@tsapeta
Copy link
Member

left a comment

Looks good, can you also add notes to the changelog?

@riwu

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Can this be merged? Current AV library is unusable because of this bug :(

@sjchmiela sjchmiela force-pushed the @sjchmiela/do_not_call_onload_on_props_update branch from 273015f to 2c426b9 Aug 6, 2019

@sjchmiela sjchmiela merged commit 2cae1dd into master Aug 6, 2019

2 of 3 checks passed

client Workflow: client
Details
docs Workflow: docs
Details
sdk Workflow: sdk
Details

@sjchmiela sjchmiela deleted the @sjchmiela/do_not_call_onload_on_props_update branch Aug 6, 2019

sjchmiela added a commit that referenced this pull request Aug 6, 2019
[expo-av] Do not reset player if source doesn't change (#5106)
# Why

Fixes #5084.

# How

`setSource:` was called whenever any prop changed (`proxiedProperties` thing). Now `setSource:` will be called only when the source actually changes.

# Test Plan

Reproducing Snack no longer alerts 'loaded' every tap.
@riwu

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

@sjchmiela I updated to the latest Expo (v34) but didn't get the fix.
Do you have to publish a new version of expo-av?

@sjchmiela

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

This bug will be fixed in standalone apps you build and is fixed in Expo client 2.12.3 which should be available as an update on the App Store shortly. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.