Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] remove suggested /apple-app-site-association #5178

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@koenpunt
Copy link
Contributor

commented Aug 4, 2019

Why

As of iOS 13 (currently still in beta), only /.well-known/apple-app-site-association will be supported, so it's good to already no longer refer to the obsolete location.

Reference: https://developer.apple.com/videos/play/wwdc2019/717/

remove suggested /apple-app-site-association
as of iOS 13, only `/.well-known/apple-app-site-association` will be supported, so it's good to already no longer refer to the obsolete location. 

Reference: https://developer.apple.com/videos/play/wwdc2019/717/

@koenpunt koenpunt changed the title remove suggested /apple-app-site-association [docs] remove suggested /apple-app-site-association Aug 5, 2019

@cruzach

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Great! Thanks for pointing this out

Could you make the same change to the version34 docs? But instead of completely removing the reference to /apple-app-site-association, just note that it won't be supported in iOS 13.

But for your changes to the unversioned page, we'll keep that the way it is now 👍

@koenpunt

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Could you make the same change to the version34 docs?

Will do.

just note that it won't be supported in iOS 13.

Why would we want that? The /.well-known/apple-app-site-association works for older platforms too, and if they implement the /apple-app-site-association they have to replace that eventually anyway.

@cruzach

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Since iOS 13 is still in beta, and we plan on fully supporting iOS 13 in the next SDK release, it seemed to make sense to include both options in the SDK 34 docs. I don't think it makes a huge difference either way, but noting that it won't be supported in iOS 13 is sort of a transition then to v35 docs where we just give the one option

@cruzach cruzach merged commit 8c67594 into expo:master Aug 6, 2019

2 of 3 checks passed

client Workflow: client
Details
docs Workflow: docs
Details
sdk Workflow: sdk
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.