Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add supports for Next.js and make sure Expo packages support server-side rendering #5275

Merged
merged 23 commits into from Aug 17, 2019
Merged

Add supports for Next.js and make sure Expo packages support server-side rendering #5275

merged 23 commits into from Aug 17, 2019

Conversation

hesyifei
Copy link
Contributor

@hesyifei hesyifei commented Aug 9, 2019 •
edited

Why

See expo/expo-cli#926.

How

Test Plan

@hesyifei hesyifei requested a review from EvanBacon August 9, 2019 19:04
@hesyifei hesyifei self-assigned this Aug 9, 2019
@hesyifei hesyifei mentioned this pull request Aug 9, 2019
Merged
@hesyifei hesyifei marked this pull request as ready for review August 12, 2019 18:58
@hesyifei hesyifei requested a review from tsapeta as a code owner August 12, 2019 18:59
@hesyifei hesyifei requested review from EvanBacon and removed request for EvanBacon August 15, 2019 22:22
@hesyifei hesyifei requested a review from ide as a code owner August 15, 2019 22:37
EvanBacon
EvanBacon approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this

@hesyifei hesyifei merged commit 89a8576 into master Aug 17, 2019
@hesyifei hesyifei deleted the @hesyifei/expo-web/nextjs branch August 17, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBacon EvanBacon EvanBacon approved these changes

@tsapeta tsapeta Awaiting requested review from tsapeta tsapeta is a code owner

@ide ide Awaiting requested review from ide ide is a code owner

Assignees

@hesyifei hesyifei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hesyifei @EvanBacon