Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-wallet] Supports adding passes to Apple Wallet unimodule #5365

Open
wants to merge 34 commits into
base: master
from

Conversation

@vivianzzhu91
Copy link
Contributor

commented Aug 16, 2019

Why

Due to this feature request, we decided to add expo-wallet module to add passes to Apple Wallet with different functionalities and UI component (the Add to Apple Wallet button) and web implementations.

How

With reference to Apple official docs and react-native-wallet, I created this module.

See also expo/expo-cli#942.

Test Plan

Tested on real devices and got all expected behaviors and event emitters working.
IMG_6852

@hesyifei

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Todo:

  • Add PKAddPassButton
  • Web support (Wallet.addPassFromUrlAsync(url) should open the URL.)
hesyifei added 16 commits Aug 19, 2019
…eners` is false
…ing an `UnavailabilityError` if `ExpoWallet.canAddPassesAsync` is not found
… `AddPassButton`
…ton` is `null`
…onentDidMount` to `render`

Or else `ExpoWalletAddPassButton` will be used before checking
…hlight` for `AddPassButton`
hesyifei added 3 commits Aug 19, 2019
@hesyifei hesyifei marked this pull request as ready for review Aug 19, 2019
@hesyifei hesyifei requested a review from esamelson Aug 19, 2019
hesyifei and others added 2 commits Aug 24, 2019
@sheepsteak

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

This is great! Will this make it into Expo SDK 35?

@esamelson

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

@sheepsteak - no, it will not; we have a pretty hard deadline for SDK 35 due to iOS 13, and this PR has not gone through review yet. However, this is going to be a bare-workflow-only module for the time being (just like expo-in-app-payments) and so at the time it does land, we will not need to wait for the next SDK version to release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.