[secure-store][ios] Fix incorrect security attribute #9264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a significant security bug. Someone using the flag
WHEN_UNLOCKED_THIS_DEVICE_ONLYwould actually get the iOS policykSecAttrAccessibleAlwaysThisDeviceOnly, one of the least secure security attributes.Why
Incorrect security attribute was applied
How
Changed it to the correct attribute
Test Plan
There are not any existing native tests that are verifying the attribute is correctly applied, and as far as I know there is no way to correctly verify it in an automated test.