[media-library] Fix getAssetsAsync crash when given invalid after value on Android
#9466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
tsapeta
approved these changes
Jul 29, 2020
barthap
added a commit
that referenced
this pull request
Jul 31, 2020
commit d56ff1c Author: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com> Date: Wed Jul 29 11:49:15 2020 +0200 [et] Move UpdateVersions from xdl to expotools (#9336) # Why Part of expo/expo-cli#2282 # How Moved some functionality of xdl's UpdateVersions to expotools and refactored `et client-build` command a little bit. # Test Plan Tested with `et client-build -p ios --release --skip-upload`, will test Android soon commit b5532de Author: Michał Czernek <czernekmichal@gmail.com> Date: Wed Jul 29 11:13:45 2020 +0200 [expo-module-template] Add unit tests in android module template. commit fc7bc75 Author: Tomasz Sapeta <tsapeta@users.noreply.github.com> Date: Wed Jul 29 10:17:35 2020 +0200 [bare-expo] Install pods commit 9bca879 Author: Bartłomiej Klocek <bartlomiej.klocek@swmansion.com> Date: Wed Jul 29 10:03:05 2020 +0200 [media-library] Fix `getAssetsAsync` crash when given invalid `after` value on Android (#9466) # Why Fixes #9440 Non-number string values caused `Integer.parseInt()` throwing uncaught `NumberFormatException` in background thread - this crashed the whole application. # How Surrounded `parseInt()` within a `try-catch` block with fallback to default value. # Test Plan Tested `getAssetsAsync({after: ... })` for different string values (both valid and invalid) on Android emulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #9440
Non-number string values caused
Integer.parseInt()throwing uncaughtNumberFormatExceptionin background thread - this crashed the whole application.How
Surrounded
parseInt()within atry-catchblock with fallback to default value.Test Plan
Tested
getAssetsAsync({after: ... })for different string values (both valid and invalid) on Android emulator.