[expo-av] Fix Audio.stopAndUnloadAsync not handling no-data on Android #9877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
IjzerenHein
force-pushed
the
@hein/expo-av/android-recording-stop
branch
from
3a25d35
to
76fae18
Compare
|
Friendly ping to @bbarthec 😃 |
bbarthec
approved these changes
Oct 9, 2020
Co-authored-by: Bartłomiej Bukowski <bartlomiej.bukowski@swmansion.com>
|
Great suggestion! I've updated the PR accordingly. Thanks for the review =D |
bbarthec
approved these changes
Oct 9, 2020
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
expo#9877) * [expo-av] Fix Audio.stopAndUnloadAsync not handling no-data on Android * [expo-av] Update changelog * [expo-av] Update build files * Update build files * Update packages/expo-av/src/Audio/Recording.ts Co-authored-by: Bartłomiej Bukowski <bartlomiej.bukowski@swmansion.com> * update build files Co-authored-by: Bartłomiej Bukowski <bartlomiej.bukowski@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1709, see #1709 (comment)
How
stopAndUnloadAsyncto always clean-up/unload even if stop failsTest Plan