Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perspective-fix #46

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@bartolkaruza
Copy link

commented Jun 20, 2017

This is a temporary fix until facebook/react-native#14646 lands.

The invertible scroll view does not work on Android 7.0.0 because of scaleY/scaleX not working without a perspective transform. This fix adds the perspective transform, only on Android. More details at the link.

@ButtersHub
Copy link

left a comment

worked for me 👍

sondremare added a commit to EdtechFoundry/react-native-gifted-messenger that referenced this pull request Aug 23, 2017

fix(android): fix problem where messages are not displayed on Android 7
Use fork of react-native-invertible-scroll-view that fixes problem where messages would not be shown on Android 7.0.0
expo/react-native-invertible-scroll-view#46
This should be fixed in RN 0.48
@brunocascio

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2017

Any updates here?

@3plusalpha

This comment has been minimized.

Copy link

commented Nov 1, 2017

worked for me too. Would be glad if the fix gets merged

@ide

This comment has been minimized.

Copy link
Member

commented Nov 1, 2017

The upstream RN fixed was merged awhile ago. Is this still needed in RN 0.49?

@bartolkaruza

This comment has been minimized.

Copy link
Author

commented Nov 2, 2017

@ide yes, this is fixed in the RN framework in 0.49 and this PR should not be merged. Instead we should encourage people to upgrade their RN version.

@ide

This comment has been minimized.

Copy link
Member

commented Nov 2, 2017

Thanks for the confirmation and sending that PR upstream =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.