Skip to content

option to add custom tags/strings and snippets inside the head tag #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

option to add custom tags/strings and snippets inside the head tag #86

wants to merge 1 commit into from

Conversation

@surfer77
Copy link

@surfer77 surfer77 commented Sep 17, 2017

I think it's important to be able to use custom code apart from script,style,and content inside the head.

almost all 3rd party apps like google analytics, intercom, google webmaster tools, etc will require you to add a custom snippets to the head of the page.

@surfer77
Copy link
Author

surfer77 commented Sep 17, 2017

this.setupCustomString(vueObject);

else if (metaItem.custom) {
                            this.metaTags += metaItem.custom + '\n';
                        }

{
        key: 'setupCustomString',
        value: function setupCustomString(customString) {
            if (customString) {
                this.custom = customString;
            } else {
                this.custom = '';
            }
        }
    }

{
        key: 'toString',
        value: function toString() {
            return '<head>\n' + this.title + this.metaTags + this.structuredData + this.style + this.custom + '</head>';
        }

@danielcherubini
Copy link
Contributor

danielcherubini commented Sep 18, 2017

sorry, but you've got compiled code there in the source file..

https://github.com/express-vue/express-vue-renderer/blob/master/src/utils/head.js

can you please write this in es5+, and submit the actual source file, not the compiled version

danielcherubini
danielcherubini requested changes Sep 18, 2017
View reviewed changes
Copy link
Contributor

@danielcherubini danielcherubini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a source file, a compiled file

@danielcherubini
Copy link
Contributor

danielcherubini commented Sep 18, 2017

also please not "custom" .. please use something more easily recognisable like "srcString" or "srcContents"

@surfer77
Copy link
Author

surfer77 commented Sep 22, 2017 •
edited
Loading

sorry, but you've got compiled code there in the source file..

https://github.com/express-vue/express-vue-renderer/blob/master/src/utils/head.js

can you please write this in es5+, and submit the actual source file, not the compiled version

I am trying to figure out what all those things mean and I will commit once I do and fix.

@danielcherubini
Copy link
Contributor

danielcherubini commented Sep 25, 2017

  1. Fork this repo
  2. clone that fork to your machine
  3. npm install
  4. now, in the src folder you will find the source files... edit the head.js in there please use flow typing https://flow.org
  5. you will find the example version in the tests/example folder
  6. write your new stuff there too..
  7. in tests/utils/head.js write a unit test for what you just wrote, tests are written using AVA.js
  8. to run the server and test it npm run debug (this needs to be manually killed and restarted when you make changes, we haven't got around to automating that)
  9. when you're ready... make a pull request..

@danielcherubini
Copy link
Contributor

danielcherubini commented Sep 29, 2017

I've done this for you in #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielcherubini danielcherubini danielcherubini requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@surfer77 @danielcherubini