Route Middleware - Implementation #16

Merged
merged 3 commits into from Apr 12, 2012

Conversation

Projects
None yet
3 participants
Contributor

ForbesLindesay commented Apr 12, 2012

Implements Issue 14

ForbesLindesay added some commits Apr 12, 2012

Removed accidental line added to methods
I had been tying doing it a different way, but changed my mind.  It's all fixed now.

tj added a commit that referenced this pull request Apr 12, 2012

Merge pull request #16 from Tuskan360/patch-1
Route Middleware - Implementation

@tj tj merged commit c0d2c4b into expressjs:master Apr 12, 2012

sadjow commented Apr 12, 2012

When we have a tag 0.0.5 with this feature?

Owner

tj commented Apr 12, 2012

the test you added is failing with:

   namespace.test.js test app.namespace(str, middleware, fn): AssertionError: 3 == 2
    at /Users/tj/projects/express-namespace/test/namespace.test.js:180:16

for me

Contributor

ForbesLindesay commented Apr 12, 2012

Sorry about that, I've submitted a new pull request which fixes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment