Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Not sure why "del" and "all" are treated separately here? It makes expres #8

Closed
wants to merge 1 commit into from

2 participants

@dontcallmedom

Not sure why "del" and "all" are treated separately here? It makes express fail on app.all() requests.

@tj
Owner
tj commented

because DEL and ALL are not http methods, so they're not in that array. I'll add some tests to make sure .all() works

@tj tj closed this pull request from a commit
@tj tj Fix app.all() support. Closes #8
all is a bit of a special-case since it invokes .get, .put, .post etc
9fb661b
@tj tj closed this in 9fb661b
@bulkan bulkan referenced this pull request
Closed

[WIP] Release/0.1.2 #43

0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 19, 2011
  1. @dontcallmedom

    Not sure why "del" and "all" are treated separately here? It makes ex…

    dontcallmedom authored
    …press fail on app.all() requests.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 2 deletions.
  1. +1 −2  index.js
View
3  index.js
@@ -1,4 +1,3 @@
-
/*!
* Express - Contrib - namespace
* Copyright(c) 2010 TJ Holowaychuk <tj@vision-media.ca>
@@ -46,7 +45,7 @@ exports.__defineGetter__('currentNamespace', function(){
* Proxy HTTP methods to provide namespacing support.
*/
-express.router.methods.concat(['del', 'all']).forEach(function(method){
+express.router.methods.forEach(function(method){
var orig = HTTPServer.prototype[method];
exports[method] = function(){
var args = Array.prototype.slice.call(arguments)
Something went wrong with that request. Please try again.