Fix Windows support for mapped and built-in URLs #43

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mscdex

... such as "/users/edit" and "/users/1/foo"

Fixes #41

@tj
expressjs member
tj commented Dec 28, 2011

we definitely shouldn't be inlining a util like this, why cant we just arr.join('/') or similar

@mscdex

Yeah I know inlining isn't ideal, but path.join does more than just arr.join('/'). It's your call, but this is definitely a significant issue on Windows.

@tj
expressjs member
tj commented Dec 28, 2011

yeah I know, I shouldn't have been using join() for anything url related, definitely a bug on my part

@tj tj added a commit that closed this pull request Dec 28, 2011
@tj tj Fixed windows path join. Closes #43 4572adf
@tj tj closed this in 4572adf Dec 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment