New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Express 4.x #90
Conversation
+1 Just tested your branch with express 4.0 and it works fine for me |
👍 |
I'll merge and publish this to NPM
|
👍 gratz |
👍 |
1 similar comment
👍 |
One thing that isn't in yet is support for I think we should add that if we're going to keep using |
👍 Also, the way I see it, the Readme should be updated, right?
should be replaced with
|
+1 |
@niftylettuce this might not be an issue with your code but it looks like the "default" content type isn't working with Express 4 yet - in express 4, req.format is undefined which seems to be causing it to literally look for an "undefined" property instead of a "default" property. I will look into this further when I get a chance. |
+1 bro 😋 |
Bump, I really want this inside my express 4 app 👍 |
ping @niftylettuce |
@niftylettuce it's okay, I don't use this library anymore, since I need 4.0 express. 👍 |
I came here because i was curious to see if there was already a PR to deal with that In any case, is there any chance this package is gonna be updated in the future? |
sorry if anyone wants to submit a new PR that is tested etc and works or something go for it then ping me and email niftylettuce@gmail.com - I've been using Koa a ton and haven't touched Express in forever. |
No description provided.