From d64bb2f886b3143f3205d4f5f4e1a1e157642501 Mon Sep 17 00:00:00 2001 From: Ben Atkin Date: Sun, 6 May 2012 23:49:06 -0600 Subject: [PATCH 1/2] use process.env.PORT. fix for #1118 --- bin/express | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/bin/express b/bin/express index b219b2faa8..2c4fad516c 100755 --- a/bin/express +++ b/bin/express @@ -181,6 +181,7 @@ var app = [ , 'var app = express();' , '' , 'app.configure(function(){' + , ' app.set(\'port\', process.env.PORT || 3000);' , ' app.set(\'views\', __dirname + \'/views\');' , ' app.set(\'view engine\', \':TEMPLATE\');' , ' app.use(express.favicon());' @@ -197,9 +198,9 @@ var app = [ , '' , 'app.get(\'/\', routes.index);' , '' - , 'http.createServer(app).listen(3000);' - , '' - , 'console.log("Express server listening on port 3000");' + , 'http.createServer(app).listen(app.set(\'port\'), function() {' + , ' console.log("Express server listening on port " + app.set(\'port\'));' + , '});' , '' ].join(eol); From 5f65c361715f4ab4bb340fec2908f81cd93069e5 Mon Sep 17 00:00:00 2001 From: Ben Atkin Date: Mon, 7 May 2012 12:51:41 -0600 Subject: [PATCH 2/2] use get() with single argument to read setting vars --- bin/express | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/express b/bin/express index 2c4fad516c..899b269d09 100755 --- a/bin/express +++ b/bin/express @@ -198,8 +198,8 @@ var app = [ , '' , 'app.get(\'/\', routes.index);' , '' - , 'http.createServer(app).listen(app.set(\'port\'), function() {' - , ' console.log("Express server listening on port " + app.set(\'port\'));' + , 'http.createServer(app).listen(app.get(\'port\'), function() {' + , ' console.log("Express server listening on port " + app.get(\'port\'));' , '});' , '' ].join(eol);