302 redirect instead of 301 #1417

Closed
arunoda opened this Issue Nov 14, 2012 · 4 comments

Comments

Projects
None yet
4 participants

arunoda commented Nov 14, 2012

Hi,

What is the reason to set 302 as the default redirect?

Owner

tj commented Nov 14, 2012

if we went with http 1.1 only we could use a 303, to me at least that makes more sense than assuming 301 for all redirects as a default

arunoda commented Nov 14, 2012

Yes.

That is better too.

On Wed, Nov 14, 2012 at 10:36 PM, TJ Holowaychuk
notifications@github.comwrote:

if we went with http 1.1 only we could use a 303, to me at least that
makes more sense than assuming 301 for all redirects as a default


Reply to this email directly or view it on GitHubhttps://github.com/visionmedia/express/issues/1417#issuecomment-10374247.

Arunoda Susiripala

@arunoda http://twitter.com/arunoda
http://gplus.to/arunodahttps://github.com/arunoda
http://www.linkedin.com/in/arunoda

Is this just a matter of changing the status = 302 to status = 303? I'd be happy to send a pull request with this change, I'm just not sure if anything else needs to be done.

https://github.com/visionmedia/express/blob/master/lib/response.js#L677

Member

jonathanong commented Sep 7, 2013

either way, it should not be 301 as it implies that the redirect is permanent

jonathanong closed this Sep 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment