Color problems in terminal with certain themes #1700

Closed
necolas opened this Issue Jul 25, 2013 · 6 comments

Comments

Projects
None yet
4 participants
@necolas

necolas commented Jul 25, 2013

This thing again :)

Running node app.js in a terminal with the Solarized dark theme (and a few others), results in this unreadable output:

Can I disable color output? Or might you be willing to use a gray that is visible in these popular themes, until they can be fixed?

The long-standing issue against Solarized: altercation/solarized#220

@necolas necolas referenced this issue in altercation/solarized Jul 25, 2013

Open

Color fix needed? #220

@passy

This comment has been minimized.

Show comment
Hide comment
@passy

passy Jul 25, 2013

+1, I usually switch to Solarized Light when I have an express app and would prefer Solarized finally fixing this, but an option to disable colors would still be helpful.

passy commented Jul 25, 2013

+1, I usually switch to Solarized Light when I have an express app and would prefer Solarized finally fixing this, but an option to disable colors would still be helpful.

@tj

This comment has been minimized.

Show comment
Hide comment
@tj

tj Jul 25, 2013

Member

you can use a non-"dev" format, the rest don't have colors, definitely a solarized thing, someone should just start a new 'official' fork haha, not sure, or maybe he can get a maintainer

Member

tj commented Jul 25, 2013

you can use a non-"dev" format, the rest don't have colors, definitely a solarized thing, someone should just start a new 'official' fork haha, not sure, or maybe he can get a maintainer

@tj tj closed this Jul 25, 2013

@necolas

This comment has been minimized.

Show comment
Hide comment
@necolas

necolas Jul 25, 2013

other themes also have this problem, but i know that you have always rejected the suggestion of making a change in your modules.

you can use a non-"dev" format, the rest don't have colors

what does this mean exactly?

necolas commented Jul 25, 2013

other themes also have this problem, but i know that you have always rejected the suggestion of making a change in your modules.

you can use a non-"dev" format, the rest don't have colors

what does this mean exactly?

@huxxe

This comment has been minimized.

Show comment
Hide comment
@huxxe

huxxe Jul 25, 2013

maybe he meant express.logger('tiny') or express.logger('short') instead of app.use(express.logger('dev')). you can format the log string by your self and just the development settings would give the 'solarized thing'. You could build the logger dev format by your own without the color output too. just looking at logger.js middleware in connect

huxxe commented Jul 25, 2013

maybe he meant express.logger('tiny') or express.logger('short') instead of app.use(express.logger('dev')). you can format the log string by your self and just the development settings would give the 'solarized thing'. You could build the logger dev format by your own without the color output too. just looking at logger.js middleware in connect

@tj

This comment has been minimized.

Show comment
Hide comment
@tj

tj Jul 25, 2013

Member

I don't think we can go changing everything just because themes are incomplete, it's easy enough to use a theme that isn't as busted, or if that guy doesn't want to maintain solarized anymore I'm sure someone else would love to

Member

tj commented Jul 25, 2013

I don't think we can go changing everything just because themes are incomplete, it's easy enough to use a theme that isn't as busted, or if that guy doesn't want to maintain solarized anymore I'm sure someone else would love to

@huxxe

This comment has been minimized.

Show comment
Hide comment
@huxxe

huxxe Jul 25, 2013

  • ^ someone should use a plain terminal with normal colors for the dev tasks instead of blinky appterminals. IDE console works also fine for me.
    Edit: that the prebuild dev log format do_have colors is a really fancy thing on its own imo ^^

huxxe commented Jul 25, 2013

  • ^ someone should use a plain terminal with normal colors for the dev tasks instead of blinky appterminals. IDE console works also fine for me.
    Edit: that the prebuild dev log format do_have colors is a really fancy thing on its own imo ^^

crito added a commit to crito/async.challenge that referenced this issue Feb 17, 2014

Change logger type for development server.
Change the *dev* logger to *short*, since log entries are not shown on a
terminal with the solarized theme.

expressjs/express#1700 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment