Unpublish 3.4.3, publish as 3.5.0 #1794

Closed
mcculloughsean opened this Issue Oct 24, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@mcculloughsean

The upgrade to connect 2.10 is a breaking change. See senchalabs/connect#943

@jonathanong

This comment has been minimized.

Show comment
Hide comment
@jonathanong

jonathanong Oct 24, 2013

Member

the intended reason for that change is for a bug fix, thus the patch bump instead of the minor bump. if its intention were a new feature, then yes, this would make sense. but you were relying on a bug.

so far, it seems you expect the router to have precedence over the static middleware even though the router is placed after the static middleware in the stack. if it worked otherwise, it was a bug.

your redirect issue could be solved easily by setting redirect: false. if that doesn't work, it's a bug.

Member

jonathanong commented Oct 24, 2013

the intended reason for that change is for a bug fix, thus the patch bump instead of the minor bump. if its intention were a new feature, then yes, this would make sense. but you were relying on a bug.

so far, it seems you expect the router to have precedence over the static middleware even though the router is placed after the static middleware in the stack. if it worked otherwise, it was a bug.

your redirect issue could be solved easily by setting redirect: false. if that doesn't work, it's a bug.

@dougwilson

This comment has been minimized.

Show comment
Hide comment
@dougwilson

dougwilson Oct 24, 2013

Member

Or by adding app.use(app.router) above the app.use(staticMiddleware) if you want the router to take precedence, of course.

Member

dougwilson commented Oct 24, 2013

Or by adding app.use(app.router) above the app.use(staticMiddleware) if you want the router to take precedence, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment