Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Checked all the examples #1357

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

sakateka commented Oct 7, 2012

No description provided.

Contributor

rauchg commented Oct 8, 2012

Thanks @sakateka. I think the project would benefit from showing off various template languages in the examples though. We might need to add layout/blocks support into EJS sooner rather than later.

@tj tj commented on the diff Oct 8, 2012

examples/auth/app.js
@@ -78,7 +78,7 @@ app.get('/', function(req, res){
});
app.get('/restricted', restrict, function(req, res){
- res.send('Wahoo! restricted area');
+ res.send('Wahoo! restricted area, click to <a href="/logout">logout</a>');
});
@tj

tj Oct 8, 2012

Owner

this stuff is all good, thanks

@tj tj commented on an outdated diff Oct 8, 2012

examples/auth/views/login.ejs
+ <title>Authentication Example</title>
+ <style>
+ body {
+ padding: 50px;
+ font: 13px Helvetica, Arial, sans-serif;
+ }
+ .error {
+ color: red
+ }
+ .success {
+ color: green;
+ }
+ </style>
+ </head>
+ <body>
@tj

tj Oct 8, 2012

Owner

might be nice to use <% include head %> and <% include foot %> here to illustrate how you can do "layouts" with EJS

Owner

tj commented Oct 8, 2012

k read through it, this is good thanks man, it would be great if we could get at least a header / footer example with EJS includes where I commended there, but if you dont have time let me know and I'll merge

Contributor

sakateka commented Oct 9, 2012

I think the title gives an example solution to a specific problem, and those who want to learn how to use ejs, will see an example of ejs first, we must expand it. I will amend the commit.

Owner

tj commented Oct 10, 2012

fixed a few things and merged, thanks!

@tj tj closed this Oct 10, 2012

Contributor

sakateka commented Oct 10, 2012

Thanks a lot for your nice work!

is there a reason why a package.json file isn't included with each example? I've went through a few examples and found it helpful to create a simple package.json file so that I could do a "npm install" and "node index" to view each example in the browser

Owner

tj commented Oct 26, 2012

no specific reason, that would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment