'views' setting for mounted apps should inherit from parent app #1394

Merged
merged 0 commits into from Aug 15, 2013

Conversation

Projects
None yet
2 participants
@evdb

evdb commented Nov 1, 2012

Attached a commit with a failing test case, and two commented out alternatives for making it pass. Option 1 is my preferred as it continues the behaviour we had in express 2.x. Option 2 would require a bit of documentation to make it clear that some settings are not inherited.

Option 1 would probably involve some thinking about which settings should be inherited. Perhaps they all should? I suspect that is what is wanted, in line with #426.

@tj tj merged commit e850cb3 into expressjs:master Aug 15, 2013

1 check failed

default The Travis CI build failed
Details
@evdb

This comment has been minimized.

Show comment Hide comment
@evdb

evdb Aug 15, 2013

Hmm - I may have inadvertently messed up this pull request by changing the branch that it was from on my own repo. No matter, after 10 months it was probably not a goer anyway :)

evdb commented Aug 15, 2013

Hmm - I may have inadvertently messed up this pull request by changing the branch that it was from on my own repo. No matter, after 10 months it was probably not a goer anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment