Inherit settings from parent application using [[Prototype]] #1503

Merged
merged 1 commit into from Apr 1, 2013

Conversation

Projects
None yet
3 participants

shesek commented Feb 8, 2013

It seems like the current code implements the exact same behavior as using [[Prototype]], so why not use it?

shesek commented Feb 8, 2013

It should also be noted that in order to check if an application has its own setting, you have to use hasOwnProperty, rather than just checking if app.settings.foo exists, which I think makes sense... but might break some code.

Member

LinusU commented Mar 14, 2013

Nice!

Owner

tj commented Apr 1, 2013

ah yup that works, we didn't have the proto stuff when this was written, thanks!

tj added a commit that referenced this pull request Apr 1, 2013

Merge pull request #1503 from shesek/settings-inheritance
Inherit settings from parent application using [[Prototype]]

@tj tj merged commit 82731da into expressjs:master Apr 1, 2013

1 check failed

default The Travis build failed
Details

@shesek shesek deleted the shesek:settings-inheritance branch Apr 23, 2013

rlidwka pushed a commit to rlidwka/express that referenced this pull request Aug 6, 2014

Merge pull request #1503 from shesek/settings-inheritance
Inherit settings from parent application using [[Prototype]]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment