Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some meta tags in examples #3860

Merged
merged 1 commit into from Mar 25, 2020
Merged

Conversation

adisrivas
Copy link
Contributor

No description provided.

@wesleytodd
Copy link
Member

Hey @adisrivas, while I have nothing against this, I also don't see any value in adding it. Things I would like to know:

  1. Does this make some experience better for express users?
  2. Are there other examples which also have (or dont have) this meta tag? If it is not consistent, would it be better to make them all consistent in one PR?

@adisrivas
Copy link
Contributor Author

Hey @wesleytodd, as these meta tags are by and large present in every template hence I added them in ejs example. Yes, there were other examples also besides ejs which do not had it, thus I have now added it in all of them.

@wesleytodd
Copy link
Member

Awesome on the response to number 2, but the real value was an answer to question 1. Does this meaningfully change the experience for developers who view the examples?

@adisrivas adisrivas changed the title made ejs example responsive for mobile devices added some meta tags in examples Jan 24, 2019
@adisrivas adisrivas changed the title added some meta tags in examples Added some meta tags in examples Jan 24, 2019
@dougwilson
Copy link
Contributor

I guess we can just add these, since (1) the meta charset would just make those the same as others that already have it and (2) the viewport change is just sadly the reality of a working mobile view, and these pages have basically no content, so 🤷‍♂.

@dougwilson dougwilson merged commit 3f1dcb9 into expressjs:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants