New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change references to "jade" to "pug" #609

Closed
crandmck opened this Issue Mar 23, 2016 · 14 comments

Comments

Projects
None yet
4 participants
@crandmck
Member

crandmck commented Mar 23, 2016

Per expressjs/express#2952, need to update http://expressjs.com/en/guide/using-template-engines.html (and search for any other instances of "jade").

@lordKnighton

This comment has been minimized.

Show comment
Hide comment
@lordKnighton

lordKnighton Mar 29, 2016

Contributor

I'm doing a few updates to express guides, i can handle this, but it will be several days or so, do you wish to take care of this, or shall i get to it?

Contributor

lordKnighton commented Mar 29, 2016

I'm doing a few updates to express guides, i can handle this, but it will be several days or so, do you wish to take care of this, or shall i get to it?

@crandmck

This comment has been minimized.

Show comment
Hide comment
@crandmck

crandmck Mar 29, 2016

Member

@lordKnighton Please do! I've been meaning to get to this, but just haven't had a chance. Thanks!!

Member

crandmck commented Mar 29, 2016

@lordKnighton Please do! I've been meaning to get to this, but just haven't had a chance. Thanks!!

@lordKnighton

This comment has been minimized.

Show comment
Hide comment
@lordKnighton

lordKnighton Mar 29, 2016

Contributor

no worries

Contributor

lordKnighton commented Mar 29, 2016

no worries

@crandmck

This comment has been minimized.

Show comment
Hide comment
@crandmck

crandmck Apr 13, 2016

Member

@lordKnighton Are you going to take another crack at this? If not, then I'll try to do it. No worries either way, just let me know.

Member

crandmck commented Apr 13, 2016

@lordKnighton Are you going to take another crack at this? If not, then I'll try to do it. No worries either way, just let me know.

@lordKnighton

This comment has been minimized.

Show comment
Hide comment
@lordKnighton

lordKnighton Apr 13, 2016

Contributor

go for it, i got swapped. I can do it next week, if you prefer me to do it.

Contributor

lordKnighton commented Apr 13, 2016

go for it, i got swapped. I can do it next week, if you prefer me to do it.

@crandmck

This comment has been minimized.

Show comment
Hide comment
@crandmck

crandmck Apr 14, 2016

Member

OK, PR updates the English docs, and I opened #618 to track task to update translated docs. Also added #617 for when the generator is updated.

@lordKnighton (or anyone) pls take a quick look at the PR ^

Member

crandmck commented Apr 14, 2016

OK, PR updates the English docs, and I opened #618 to track task to update translated docs. Also added #617 for when the generator is updated.

@lordKnighton (or anyone) pls take a quick look at the PR ^

@lordKnighton

This comment has been minimized.

Show comment
Hide comment
@lordKnighton

lordKnighton Apr 14, 2016

Contributor

👍

Contributor

lordKnighton commented Apr 14, 2016

👍

@crandmck

This comment has been minimized.

Show comment
Hide comment
@crandmck

crandmck Apr 14, 2016

Member

Thanks!
We'll address non-en docs as time permits, and generator docs when the generator is updated.

Member

crandmck commented Apr 14, 2016

Thanks!
We'll address non-en docs as time permits, and generator docs when the generator is updated.

@crandmck crandmck closed this Apr 14, 2016

@lordKnighton

This comment has been minimized.

Show comment
Hide comment
@lordKnighton

lordKnighton Apr 14, 2016

Contributor

+1

Contributor

lordKnighton commented Apr 14, 2016

+1

@martinjoiner

This comment has been minimized.

Show comment
Hide comment
@martinjoiner

martinjoiner Feb 13, 2017

Contributor

Hey guys. I am a firs-timer here on this repo. I would like to contribute by replacing references to Jade with Pug in the "Express Application Generator" page http://expressjs.com/en/starter/generator.html I recently got confused when followed this guide to bootstrap a project and then tried to find Jade documentation. Is it OK to go ahead and fork, edit and create a pull request?

Contributor

martinjoiner commented Feb 13, 2017

Hey guys. I am a firs-timer here on this repo. I would like to contribute by replacing references to Jade with Pug in the "Express Application Generator" page http://expressjs.com/en/starter/generator.html I recently got confused when followed this guide to bootstrap a project and then tried to find Jade documentation. Is it OK to go ahead and fork, edit and create a pull request?

@crandmck

This comment has been minimized.

Show comment
Hide comment
@crandmck

crandmck Feb 13, 2017

Member

Hi @martinjoiner thanks for offering to contribute.

This seems reasonable, and IIRC, the only reason we haven't made this change was because Pug was still in beta. Although npm still says version if 2.0.0-beta11, it's replaced Jade now for quite a while, so I'm not sure if this is still an issue.

Even though the generator still supports Jade, I agree we should start nudging people toward Pug, since it's being maintained instead of Jade now (due to the naming issue).

However, I'll defer to @dougwilson on this.... Doug, should we wait for Pug non-beta release to make this sort of change?

Member

crandmck commented Feb 13, 2017

Hi @martinjoiner thanks for offering to contribute.

This seems reasonable, and IIRC, the only reason we haven't made this change was because Pug was still in beta. Although npm still says version if 2.0.0-beta11, it's replaced Jade now for quite a while, so I'm not sure if this is still an issue.

Even though the generator still supports Jade, I agree we should start nudging people toward Pug, since it's being maintained instead of Jade now (due to the naming issue).

However, I'll defer to @dougwilson on this.... Doug, should we wait for Pug non-beta release to make this sort of change?

@dougwilson

This comment has been minimized.

Show comment
Hide comment
@dougwilson

dougwilson Feb 14, 2017

Member

I don't see any reason any longer not to just update that generator page to use --view=pug if that reduces confusion 😄

Member

dougwilson commented Feb 14, 2017

I don't see any reason any longer not to just update that generator page to use --view=pug if that reduces confusion 😄

@martinjoiner

This comment has been minimized.

Show comment
Hide comment
@martinjoiner

martinjoiner Feb 14, 2017

Contributor

I have forked, edited and created a pull request (#785). My initial motivation for making this change was to save confusion for English-speaking new adopters. However, as I worked on the different language versions I realise how the real win here is for the non-English-speaking users who might find it harder than I did to learn about the forced renaming.

Contributor

martinjoiner commented Feb 14, 2017

I have forked, edited and created a pull request (#785). My initial motivation for making this change was to save confusion for English-speaking new adopters. However, as I worked on the different language versions I realise how the real win here is for the non-English-speaking users who might find it harder than I did to learn about the forced renaming.

@crandmck

This comment has been minimized.

Show comment
Hide comment
@crandmck

crandmck Feb 14, 2017

Member

Landed #785. Thanks @martinjoiner !

Member

crandmck commented Feb 14, 2017

Landed #785. Thanks @martinjoiner !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment