New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory as app name #18

Merged
merged 1 commit into from Apr 18, 2014

Conversation

Projects
None yet
3 participants
@sheepsteak
Copy link
Contributor

sheepsteak commented Apr 12, 2014

Had a go at implementing #17

@defunctzombie

This comment has been minimized.

Copy link
Contributor

defunctzombie commented Apr 12, 2014

What if the user specifies a path?

@sheepsteak

This comment has been minimized.

Copy link
Contributor Author

sheepsteak commented Apr 13, 2014

Crap. I forgot about that. I usually use express app or just express . 😒

Rather than messing about with the path it would probably be better to make it an option then? Or just scrap it all together and let the user change it in the two places it needs to?

@defunctzombie

This comment has been minimized.

Copy link
Contributor

defunctzombie commented Apr 13, 2014

I think you could use path.dirname or path.resolve BTW :)
On Apr 13, 2014 7:24 AM, "Chris Shepherd" notifications@github.com wrote:

Crap. I forgot about that. I usually use express app or just express . [image:
😒]

Rather than messing about with the path it would probably be better to
make it an option then? Or just scrap it all together and let the user
change it in the two places it needs to?

Reply to this email directly or view it on GitHubhttps://github.com//pull/18#issuecomment-40305256
.

@sheepsteak

This comment has been minimized.

Copy link
Contributor Author

sheepsteak commented Apr 17, 2014

Now using path.resolve 😄

@defunctzombie

This comment has been minimized.

Copy link
Contributor

defunctzombie commented Apr 17, 2014

please squash commits into one and I will merge

Use directory name as app name
Changed output message too

Using last part of path as app name
@sheepsteak

This comment has been minimized.

Copy link
Contributor Author

sheepsteak commented Apr 17, 2014

Done.

defunctzombie added a commit that referenced this pull request Apr 18, 2014

@defunctzombie defunctzombie merged commit 216f05e into expressjs:master Apr 18, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

dougwilson pushed a commit that referenced this pull request Jun 30, 2016

cwonrails pushed a commit to cwonrails/generator that referenced this pull request Apr 29, 2018

Merge pull request expressjs#18 from tachyons-css/api
Publish tachyons config and styleguide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment