Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Cases [tests pass on all os] #832

Conversation

3imed-jaberi
Copy link
Member

@3imed-jaberi 3imed-jaberi commented Jan 18, 2020

  • fix all test case ..

fixed-test-case

  • add the coverage script by add nyc istanbul.

istanbul-coverage

nyc..

add-coverage

  • update the ci pipeline.
  • cleanup .gitignore + locks.

merge #831 #830 #829 here ..
fix #181 #827 #829 ..

@3imed-jaberi 3imed-jaberi changed the title Merge update ci fix tests add coverage cleanup ignore file Fix Test Cases + Add Coverage + Update CI pipeline Jan 18, 2020
Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing! First for feedback, this PR changes too many things to be easily evaluated.

Can you open an issue describing the things you are trying to fix or enhance individually? That makes it much easier to track discussions and focus on individual issues.

For example, I can't reproduce the tests failing. It might be a good idea to add more Node versions into CI, but that's it's own issue alone. As is adding code coverage. There's also formatting changes, this introduces a yarn.lock file, and ignores and disables package-lock files.

Also, there are 33 people who have contributed to this package in some way, but you'll notice that only 3 are listed as contributors in package.json. I'm not the person who decides who gets listed there, or how that works, but I wanted to point that out 😉

@3imed-jaberi
Copy link
Member Author

3imed-jaberi commented Jan 18, 2020

Thank you very much for contributing! First for feedback, this PR changes too many things to be easily evaluated.

Can you open an issue describing the things you are trying to fix or enhance individually? That makes it much easier to track discussions and focus on individual issues.

For example, I can't reproduce the tests failing. It might be a good idea to add more Node versions into CI, but that's it's own issue alone. As is adding code coverage. There's also formatting changes, this introduces a yarn.lock file, and ignores and disables package-lock files.

Also, there are 33 people who have contributed to this package in some way, but you'll notice that only 3 are listed as contributors in package.json. I'm not the person who decides who gets listed there, or how that works, but I wanted to point that out 😉

@jonchurch, thank you for your answer ..
I gathered them here because I see that they are related to each other .. If you want to separate them, tell me and I will do it right away ( you can re-open #828 #830 #831) ..
 As for the issues, I have opened two issues: #827 and #829, which are about the tests that fail and the coverage. I also spoke about the continuous integration pipeline which is very old and has no actual test / coverage ..

Regarding the subject of adding my name, I used to think that every contributor added his name .. I did not know that someone was decide putting people there ..
I will wait for your decision to separate each pr or review this request, then I will delete my name ...

@3imed-jaberi 3imed-jaberi force-pushed the merge-update-ci-fix-tests-add-coverage-cleanup-ignore-file branch from c405b45 to 5c1ac0b Compare June 2, 2020 00:00
@3imed-jaberi 3imed-jaberi force-pushed the merge-update-ci-fix-tests-add-coverage-cleanup-ignore-file branch from d637e43 to 0a32d17 Compare June 2, 2020 00:17
@3imed-jaberi 3imed-jaberi force-pushed the merge-update-ci-fix-tests-add-coverage-cleanup-ignore-file branch from 0a32d17 to a1329d1 Compare June 2, 2020 00:21
@3imed-jaberi 3imed-jaberi changed the title Fix Test Cases + Add Coverage + Update CI pipeline Fix Test Cases [tests pass on all os] Jun 2, 2020
@3imed-jaberi
Copy link
Member Author

I will close this PR due to lack of interaction ..
If anyone need this PR, you can leave a comment and I will reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fails because of line endings on windows
2 participants