Skip to content

refactor: improve code readability#105

Merged
rsaz merged 4 commits into
expressots:mainfrom
mohanadft:main
Sep 25, 2023
Merged

refactor: improve code readability#105
rsaz merged 4 commits into
expressots:mainfrom
mohanadft:main

Conversation

@mohanadft
Copy link
Copy Markdown
Contributor

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • The commit message follows our guidelines:
    • A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity.
    • We use Microverse's commit message convention
    • The convention stablish that a commit message has to be in the present tense, imperative and lowercase.
    • Example: fix typo in README.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Some refactoring to enhance code readability.

Issue Number: N/A

What is the new behavior?

Describe the new behavior or link to a relevant issue.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

Other information

Any other information that is important to this PR.

@ghost
Copy link
Copy Markdown

ghost commented Sep 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Comment thread packages/core/src/application/application-factory.ts
Comment thread packages/core/src/application/application-factory.ts
Comment thread packages/core/src/application/application-factory.ts
Comment thread packages/core/src/application/application-factory.ts
Copy link
Copy Markdown
Member

@rsaz rsaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting object to the base-controller is ok.

@rsaz rsaz assigned rsaz and mohanadft and unassigned rsaz Sep 25, 2023
@rsaz rsaz added the enhancement New feature or request label Sep 25, 2023
@rsaz rsaz merged commit 5ecd8a0 into expressots:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants