Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cowboy_loop_handler's don't work with spdy #671

Closed
fishcakez opened this issue Feb 8, 2014 · 3 comments
Closed

cowboy_loop_handler's don't work with spdy #671

fishcakez opened this issue Feb 8, 2014 · 3 comments

Comments

@fishcakez
Copy link
Contributor

cowboy_spdy does not have all the ranch_transport callbacks. In particular it does not have setopts/2 and messages/0, so a cowboy_loop_handler will exit with an undef error.
@essen
Copy link
Member

essen commented Feb 20, 2014

It will take a while. I would like to add HTTP to gun, convert the test suite to use gun instead of cowboy_client, and add a few groups for testing most of everything we test with HTTP, except over SPDY this time (just like we do with SSL). Then only can we be sure it all works as intended.

@fishcakez
Copy link
Contributor Author

Sounds great, thank you!

@essen essen added the 0.10 label Mar 25, 2014
@essen
Copy link
Member

essen commented Apr 26, 2014

Fixed in 980342f. Thanks!

@essen essen closed this as completed Apr 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@essen @fishcakez