New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext.Net.MenuPanel item selection does not work well #1518

Closed
fabriciomurta opened this Issue Aug 1, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@fabriciomurta
Contributor

fabriciomurta commented Aug 1, 2017

Found: 4.3.0

This is a recurrence of #869. Once again, focusing mechanism has changed and this no longer works. There should be a theme-compatible change here to alter the CSS class of the selected entry in order to both display it in a different tone/highlight and not be confused with mouse hover highlight. And not likely to break on next releases.

As the component is Ext.NET specific, we're not tagging it after 'sencha' although the change is necessary due to ExtJS change on the way it works.

@fabriciomurta fabriciomurta added this to the 4.3.0 milestone Aug 1, 2017

@fabriciomurta fabriciomurta self-assigned this Aug 1, 2017

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Aug 2, 2017

Contributor

We expect the way it works now will address the "same color" issue with selected and highlighted/hovered menu entries as it defaults to using the same color scheme from the grid panel for the selected entry.

Also, now relying on binding/removing CSS classes to the menu entries instead of intercepting the focus event should make this approach robust and not needing reviews on the next ExtJS releases.

Contributor

fabriciomurta commented Aug 2, 2017

We expect the way it works now will address the "same color" issue with selected and highlighted/hovered menu entries as it defaults to using the same color scheme from the grid panel for the selected entry.

Also, now relying on binding/removing CSS classes to the menu entries instead of intercepting the focus event should make this approach robust and not needing reviews on the next ExtJS releases.

fabriciomurta added a commit to extnet/Ext.NET.Examples that referenced this issue Aug 5, 2017

Reviews the MenuPanel example to illustrate a new functionality.
This adds a CSS class and uses it on the first menu accordion,
illustrating the new SelectedCls and SelectedTextCls functionality
introduced on Ext.NET 4.3.0 via extnet/Ext.NET#1518.

This also adds IDs for easier handling of the individual menus
throughout the example. This easier console access is useful for debugging and
testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment