New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext.Net.RowExpander: typo breaks grid if used with locking #1530

Closed
fabriciomurta opened this Issue Aug 18, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@fabriciomurta
Contributor

fabriciomurta commented Aug 18, 2017

Found: 4.3.0
Ext.NET forum thread: LockedColumns with RowExpander

A typo in the client-side Ext.net.RowExpander.init() code breaks script execution on load if the grid attached to the RowExpander plug in uses locking.

This issue has been tracked down to September 8th, 2014, on commit extnet/Premium@ad44e88.

It references to the view variable in global namespace (window.view) as it is not defined in the method via var view anywhere. It was not a leftover because the offending line was introduced in that commit and no line defining a local view variable was removed from the method in that commit.

@fabriciomurta fabriciomurta added this to the 4.4.0 milestone Aug 18, 2017

@fabriciomurta fabriciomurta self-assigned this Aug 18, 2017

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Aug 22, 2017

Contributor

The rowExpander plug in on the grid panel won't work with SingleExpand="true". CacheSingleExpandRows do not affect the issue at all.

Contributor

fabriciomurta commented Aug 22, 2017

The rowExpander plug in on the grid panel won't work with SingleExpand="true". CacheSingleExpandRows do not affect the issue at all.

@fabriciomurta fabriciomurta reopened this Aug 22, 2017

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Aug 22, 2017

Contributor

the Ext.net.RowExpander.toggleRow() method had issues and could use a good refactoring, which was done, and should work well from now on.

Contributor

fabriciomurta commented Aug 22, 2017

the Ext.net.RowExpander.toggleRow() method had issues and could use a good refactoring, which was done, and should work well from now on.

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Aug 24, 2017

Contributor

We received positive feedback from the reporting user in the respective forum thread, so this issue's fix is now good to go live.

Contributor

fabriciomurta commented Aug 24, 2017

We received positive feedback from the reporting user in the respective forum thread, so this issue's fix is now good to go live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment