New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotlight's show() method support for component as argument is broken #1553

Closed
fabriciomurta opened this Issue Sep 28, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@fabriciomurta
Contributor

fabriciomurta commented Sep 28, 2017

Found: 4.4.1
Ext.NET forum thread: Spotlight control not working as per examples page

The Ext.ux.Spotlight component's show() method used to support being called with a component argument instead an Ext.dom.Element one. This is no longer the case at least since ExtJS 6.5.1.

This have broken the Spotlight Overview sample at the Examples Explorer.

The documentation for the show() method is not clear whether the argument should be an Ext.dom.Element or may support something else, so this should be assumed as a Sencha breaking change.

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Sep 28, 2017

Contributor

ExtJS version of Spotlight does not support a component on the show() method at least since ExtJS 6.2.1, so this should be considered an exclusive Ext.NET feature and implemented back.

Contributor

fabriciomurta commented Sep 28, 2017

ExtJS version of Spotlight does not support a component on the show() method at least since ExtJS 6.2.1, so this should be considered an exclusive Ext.NET feature and implemented back.

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Sep 29, 2017

Contributor

The fix implements back support for specifying a component reference as parameter to the spotlight's show() method.

Contributor

fabriciomurta commented Sep 29, 2017

The fix implements back support for specifying a component reference as parameter to the spotlight's show() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment