New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Grid Filter's events #1594

Closed
fabriciomurta opened this Issue Jun 20, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@fabriciomurta
Contributor

fabriciomurta commented Jun 20, 2018

Found: 4.6.0
Ext.NET forum thread: Clear value in a GridPanel Column Filter
There are no such events according to Sencha documentation at http://docs.sencha.com/extjs/6.5.3/classic/Ext.grid.filters.filter.String.html

This was probably a left over from Ext.NET 2.x, where gridfilters were a grid panel's feature, not a plugin as it is currently.

So, according to the documentation, the following can be inferred:

  • there's no Activate/Deactivate events in the component anymore
  • there's still an 'active' property and setter methods to handle its active state
  • the documentation on setActive() states it sets the state and triggers the corresponding events (not clear)

As suggested by the setActive documentation entry, setting the grid store's FilterChange event, the filter changing events are triggered and can be handled from there.

So Ext.NET code should no longer export the events bound to intellisense.

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Jun 20, 2018

Contributor

The class directly affected by this change should be Ext.Net.GridFilter; the listeners should completely be removed from it.

Contributor

fabriciomurta commented Jun 20, 2018

The class directly affected by this change should be Ext.Net.GridFilter; the listeners should completely be removed from it.

@fabriciomurta fabriciomurta modified the milestones: 4.x, 4.7.0 Aug 7, 2018

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Aug 7, 2018

Contributor

Removed. Albeit a breaking change, this is probably not working before version 4 release.

Contributor

fabriciomurta commented Aug 7, 2018

Removed. Albeit a breaking change, this is probably not working before version 4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment