Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Ext.Net.Theme.Default to Ext.Net.Theme.Classic #1602

Closed
fabriciomurta opened this issue Aug 4, 2018 · 1 comment

Comments

@fabriciomurta
Copy link
Contributor

commented Aug 4, 2018

It's been a long time since the Classic theme no longer is the default Ext.NET's theme. There's no point in having it figure as Default as it is not only misleading, but hides the actual theme name.

Edit: Renamed "blue" references to "classic", as this refers to the actual theme files in the sources.

@fabriciomurta fabriciomurta added this to the 5.0 milestone Aug 4, 2018
@fabriciomurta fabriciomurta changed the title Rename Ext.Net.Theme.Default to Ext.Net.Theme.Blue Rename Ext.Net.Theme.Default to Ext.Net.Theme.Classic Sep 9, 2019
fabriciomurta added a commit to extnet/examples.ext.net that referenced this issue Sep 10, 2019
The theme has not been the default Ext.NET theme for a long long time,
and in Ext.NET 5 the theme name was changed to reflect its actual theme
name in Ext JS, which is 'classic'.

References to 'blue' as the name as well as the enum reference,
Ext.Net.Theme.Default, changed to Ext.Net.Theme.Classic.

This comes as a consequence of extnet/Ext.NET#1602.
fabriciomurta added a commit to extnet/mvc.ext.net that referenced this issue Sep 10, 2019
The theme has not been the default one for a long long time, and in
Ext.NET 5 its name was changed to reflect the name currently used in Ext
JS: 'classic'.

References to 'blue' as the theme name, as well as the enum reference,
Ext.Net.Theme.Default were changed accordingly.

This comes as a conseuence of extnet/Ext.NET#1602.
@fabriciomurta fabriciomurta self-assigned this Sep 10, 2019
@fabriciomurta

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

All references to Ext.Net.Theme.Default have been changed to Ext.Net.Theme.Classic. Besides, references to the Blue theme name in Examples Explorers were also changed to "Classic". This "default" theme enum was usually the only exception to loops thru theme names, which it usually mapped Default theme handle to the name Blue. Now both are simply Classic, as used by Ext JS.

fabriciomurta added a commit to extnet/examples.ext.net that referenced this issue Sep 13, 2019
The affected example relies in the Blue (now known as "Classic" in Ext
JS) to show how to completely customize the looks of a grid.

Related github issue: extnet/Ext.NET#1602.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.