New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuerySelector down() breaks if there's a Chart with SpriteLegend within #1606

Closed
fabriciomurta opened this Issue Aug 6, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@fabriciomurta
Contributor

fabriciomurta commented Aug 6, 2018

Found: 4.7.0
Sencha thread: down ( [selector] ) method doesn't work?

Ext.chart.legend.SpriteLegend now is an 'item' within a chart when SpriteLegend is used. But it doesn't implement, for one, the .isXType() method. So using the down() querier will raise an exception if this class is in the path.

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Aug 6, 2018

Contributor

Fiddle reproducing (and showing a fix) for the issue: Sprite Legend / Component Query Error

Contributor

fabriciomurta commented Aug 6, 2018

Fiddle reproducing (and showing a fix) for the issue: Sprite Legend / Component Query Error

@fabriciomurta

This comment has been minimized.

Show comment
Hide comment
@fabriciomurta

fabriciomurta Aug 7, 2018

Contributor

Fixed by our own by now. The Sencha issue is likely to become an actual issue and be fixed, so let's keep an eye on that for next Ext JS releases.

Contributor

fabriciomurta commented Aug 7, 2018

Fixed by our own by now. The Sencha issue is likely to become an actual issue and be fixed, so let's keep an eye on that for next Ext JS releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment