Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext.menu.Item override relies on non-existing getIconUrl() method #1617

Closed
fabriciomurta opened this Issue Nov 3, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@fabriciomurta
Copy link
Contributor

fabriciomurta commented Nov 3, 2018

Found: 4.7.1
Ext.NET issue: Button overflow menu - set icon class returns error

The Ext.menu.Item override from Ext.NET relies on the class' getIconCls(), which does not exist and is not expected to, according to Sencha Ext JS documentation on the class.

So, Ext.NET override simply needs to rely in this.iconCls instead of this.getIconCls().

@fabriciomurta fabriciomurta added this to the 4.7.2 milestone Nov 3, 2018

@fabriciomurta fabriciomurta self-assigned this Nov 3, 2018

@fabriciomurta fabriciomurta modified the milestones: 4.7.2, 4.8.0 Feb 20, 2019

@fabriciomurta

This comment has been minimized.

Copy link
Contributor Author

fabriciomurta commented Feb 20, 2019

Fixed with reviewing the override. We won't add a 'override removal pending' due to the nature of this change not being to solve an ExtJS-specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.