Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext.data.Query incompatibility with GridFilters GridPanel plugin #1628

Closed
fabriciomurta opened this Issue Feb 12, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@fabriciomurta
Copy link
Contributor

fabriciomurta commented Feb 12, 2019

Found: 4.8.0 (during development)
Ext.NET forum thread: N/A
Sencha thread: [6.7.0 classic] The new Ext.data.Query issue with GridFilters plugin

While using the GridFilters plugin with a GridPanel, the newly introduced Query filter triggers an error, at least, the second time the grid store's addFilter() method is called while passing an Ext.data.Query filter.

This can be reproduced in the following Sencha Fiddle: GridPanel + GridFilters + Ext.data.Query issue.

To easily reproduce this in an Ext.NET example, use the GridPanel > Plugins > GridFilters_Local and call this client-side code twice:

App.Store1.addFilter(new Ext.data.Query("Company like \"Co\" or Size = \"large\""));

Note: For the Ext.data.Query class to exist, it is imperative that the Ext JS version is at least 6.7.0.

It is possible that any addFilter() call after the first with Ext.data.Query will throw the exception, as the actual requirement is to call removeFilter() when there's at least one Ext.data.Query filter applied.

@fabriciomurta

This comment has been minimized.

Copy link
Contributor Author

fabriciomurta commented Feb 13, 2019

Fixed with the same override as suggested in the Sencha thread (stub Ext.data.Query.getProperty as Ext.emptyFn).

@fabriciomurta fabriciomurta modified the milestones: 4.x, 4.8.0 Feb 13, 2019

@fabriciomurta fabriciomurta self-assigned this Feb 13, 2019

@fabriciomurta

This comment has been minimized.

Copy link
Contributor Author

fabriciomurta commented Feb 23, 2019

Update: Issue still open after ExtJS 6.7.0.161 release. Issue has not been reviewed by Sencha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.