refactor(cfg): use distinct cfg for php version

[Xenira]

Refs: #334

[Xenira]

@joehoyle can you have a look at this as well? Was split out from #334

[joehoyle]

Thanks for splitting this out. Now we have a distinct PR, could you explain the motivation and advantages to doing this? This pattern was presumably introduced so you could be additive when checking for versions, e.g. "If we're on PHP 8.1, use a u16". The implication being that those kind of changes are very likely to be "PHP 8.1+" rather than just PHP 8.1.

I see you are instead recommending the pattern of "exclude all versions that wouldn't have that change" (e.g. not(any(7.4,8.0)). It's not really clear to me why this is any better?

[Xenira]

Tbh I kinda forgot why I went this direction.

Will try to reproduce why I needed that change. But you are right, that it might be more intuitive the way it was. Bit in that case 8.1 should be changed to have the same behaviour.