This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Perf - DOMRenderer: Recycle operations are expensive #454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Cleaning up the DOM elements in the renderer (recycling) is expensive, because of all the styling manipulations.
Fix: Batch up the cleanup and set it up to not block rendering. Essentially we throw the recycled elements off to the side and queue them up to be 'unstyled', before making them available to be reused.
This is the trace I was optimizing:
The test is basically hold down
j
andk
. #229 is tracking thewalker
bottleneck.