Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Perf - DOMRenderer: Recycle operations are expensive #454

Merged
merged 3 commits into from May 16, 2017

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented May 16, 2017

Issue: Cleaning up the DOM elements in the renderer (recycling) is expensive, because of all the styling manipulations.

Fix: Batch up the cleanup and set it up to not block rendering. Essentially we throw the recycled elements off to the side and queue them up to be 'unstyled', before making them available to be reused.

This is the trace I was optimizing:
image

The test is basically hold down j and k. #229 is tracking the walker bottleneck.

@bryphe bryphe merged commit 9e2f51b into master May 16, 2017
@bryphe bryphe deleted the extr0py/perf/batch-recycle-cleanup branch August 24, 2017 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant