Skip to content

Commit

Permalink
jshint, maintenance
Browse files Browse the repository at this point in the history
  • Loading branch information
extrabacon committed Mar 7, 2014
1 parent 65d210f commit 93fc0a7
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 19 deletions.
3 changes: 1 addition & 2 deletions .gitignore
@@ -1,5 +1,4 @@
.idea
npm-debug.log
*.pyc
node_modules
deps
examples/output*
Expand Down
9 changes: 9 additions & 0 deletions .jshintrc
@@ -0,0 +1,9 @@
{
"predef": [],
"browser": false,
"node": true,
"curly": false,
"strict": false,
"expr": true,
"unused": "vars"
}
1 change: 0 additions & 1 deletion .npmignore
@@ -1,4 +1,3 @@
.idea/
deps/
python/openpyxl/
python/xlrd/
Expand Down
2 changes: 0 additions & 2 deletions .tm_properties

This file was deleted.

25 changes: 11 additions & 14 deletions README.md
Expand Up @@ -31,7 +31,6 @@ dependencies are:
+ [xlrd](http://github.com/python-excel/xlrd), by Python Excel
+ [xlwt](http://github.com/python-excel/xlwt), also by Python Excel
+ [XlsxWriter](http://github.com/jmcnamara/XlsxWriter), by John McNamara
+ [openpyxl](http://bitbucket.org/ericgazoni/openpyxl), by Eric Gazoni

## Documentation

Expand Down Expand Up @@ -110,16 +109,16 @@ var SpreadsheetReader = require('pyspreadsheet').SpreadsheetReader;
var reader = new SpreadsheetReader('examples/sample.xlsx');

reader.on('open', function (workbook) {
// file is open
console.log('opened ' + workbook.file);
// file is open
console.log('opened ' + workbook.file);
}).on('data', function (data) {
// data is being received
console.log('buffer contains %d rows from sheet "%s"', data.rows.length, data.sheet.name);
// data is being received
console.log('buffer contains %d rows from sheet "%s"', data.rows.length, data.sheet.name);
}).on('close', function () {
// file is now closed
console.log('file closed');
// file is now closed
console.log('file closed');
}).on('error', function (err) {
throw err;
throw err;
});
```

Expand Down Expand Up @@ -167,8 +166,8 @@ var writer = new SpreadsheetWriter();
writer.write(0, 0, 'hello world!');

writer.save('examples/output.xlsx', function (err) {
if (err) throw err;
console.log('file saved!');
if (err) throw err;
console.log('file saved!');
});
```

Expand Down Expand Up @@ -252,7 +251,7 @@ writer.save('examples/output.xlsx', function (err) {

+ Tested with Node 0.10.x
+ Tested on Mac OS X 10.8
+ Tested on Ubuntu Linux 12.04 (requires prior installation of curl: apt-get install curl)
+ Tested on Ubuntu Linux 12.04
+ Tested on Heroku

## Dependencies
Expand All @@ -261,10 +260,8 @@ writer.save('examples/output.xlsx', function (err) {
+ [xlrd](http://www.python-excel.org/) version 0.7.4+
+ [xlwt](http://www.python-excel.org/) version 0.7.5+
+ [XlsxWriter](http://xlsxwriter.readthedocs.org/en/latest/index.html) version 0.3.6+
+ [openpyxl](http://openpyxl.readthedocs.org/en/latest/) version 1.6.2+
+ underscore
+ bash (installation script)
+ curl (installation script)
+ wget or curl (installation script)

## License

Expand Down
9 changes: 9 additions & 0 deletions test/.jshintrc
@@ -0,0 +1,9 @@
{
"predef": ["describe", "it", "before", "after", "beforeEach", "afterEach"],
"browser": false,
"node": true,
"curly": false,
"strict": false,
"expr": true,
"unused": "vars"
}

0 comments on commit 93fc0a7

Please sign in to comment.