Allowed PythonShell to work with unset std streams #190 #191
Conversation
The std streams might not be available when using the stdio option.
|
|
||
| should(pyshell.stdin).be.eql(null); | ||
| should(pyshell.stdout).be.eql(null); | ||
| should(pyshell.stderr).be.eql(null); |
There was a problem hiding this comment.
Why is stdout and stderr null? Because these both inherit the parent's stdout / stderr shouldn't they have a value?
There was a problem hiding this comment.
They should be null. The underlying code does a file descriptor dup() so the child process just inherits the file descriptors directly and then all output goes to /dev/tty (for instance, if you are working in a terminal) bypassing any streams in memory in the local process (in the case of using inherit).
| // 3 different ways of assigning values to the std streams in child_process.spawn() | ||
| // * ignore - pipe to /dev/null | ||
| // * inherit - inherit fd from parent process; | ||
| // * process.stderr - pass output directly to that stream. |
There was a problem hiding this comment.
I read up on https://nodejs.org/api/child_process.html#child_process_options_stdio, interesting stuff, thanks!
|
@extrabacon can you configure the appveyor webhook in settings please? This PR should have triggered a build there :/ In the meantime I'll merge this PR in and see if it passes tests on the main branch |
The std streams might not be available when using the stdio option.