New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last run metadata on messages #33

Merged
merged 1 commit into from May 12, 2018

Conversation

Projects
None yet
3 participants
@JeppeKnockaert
Contributor

JeppeKnockaert commented May 3, 2018

Issue

Sending an Overdue message in a notification fails, because of a 'property of non-object' exception on line 39 in Overdue.php.

Solution

Fetch last run the same way as in eye/resources/views/dashboard/tabs/scheduler.blade.php.

I've added some tests that fail without the fix and succeed after the fix.

@laurencei

This comment has been minimized.

Contributor

laurencei commented May 6, 2018

Thanks @JeppeKnockaert - I'm just running this on some production builds - but looks good.

I'll merge it shortly.

@laurencei laurencei merged commit ee92126 into eyewitness:beta May 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment