New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Layout/IndentHash and Layout/IndentArray to consistent style #59

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
5 participants
@aprescott
Copy link
Contributor

aprescott commented Jan 10, 2019

What did we change?

Sets the Layout/IndentHash and Layout/IndentArray cops to enforce consistent style.

Why are we doing this?

The Style Council decided to set Layout/IndentHash to consistent. Per a comment, for consistency(!), the same is applied to Layout/IndentArray.

How was it tested?

  • Specs
  • Locally

@aprescott aprescott requested review from wpeterson , bjackson2 and kristenlk Jan 10, 2019

@aprescott

This comment has been minimized.

Copy link
Contributor

aprescott commented Jan 10, 2019

Fun fact: I only realized today that the person who proposed the change makes the PR to apply it. 😁

@wpeterson

This comment has been minimized.

Copy link
Contributor

wpeterson commented Jan 10, 2019

FWIW: The bundler issue is failing on master as well (no builds have run for this gem in a month). Was there a version of a gem yanked or something?

@wpeterson
Copy link
Contributor

wpeterson left a comment

CircleCI bundler fix is merged in #60

Once you rebase off of that, this should pass CI and it LGTM

@aprescott aprescott force-pushed the ap-layout-indent branch from 58adc44 to c125549 Jan 10, 2019

@agrobbin
Copy link
Contributor

agrobbin left a comment

🎉

@codeclimate

This comment has been minimized.

Copy link

codeclimate bot commented Jan 10, 2019

Code Climate has analyzed commit c125549 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.3% (0.0% change).

View more on Code Climate.

@mjfaga

mjfaga approved these changes Jan 11, 2019

Copy link
Contributor

mjfaga left a comment

This makes me very happy 🎉

@aprescott aprescott merged commit 9572d9a into master Jan 11, 2019

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 98% (0.0% change)
Details

@aprescott aprescott deleted the ap-layout-indent branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment